[libcaca] Re: Problem with myman and libcaca : bitmap2

["Ben Wiley Sittler" <bsittler@gmail.com>]

On Feb 2, 2008 9:58 AM, Sam Hocevar <sam@zoy.org> wrote:
> On Sat, Feb 02, 2008, Ben Wiley Sittler wrote:
>
> > >  - the bitmap mode seems to have refresh bugs (Linux amd64 here) as can
> > >    be seen on http://zoy.org/~sam/myman-refresh-bug.png
> >
> > Interesting! What fonts are you using? And is that using the X11 driver?
>
>    It happens with every libcaca output driver (ncurses, slang, x11). I
> only need to set OPTCURSES_BITMAP=t and -z kpac. This is with libcucul
> 0.99.beta13b.

So far I have not been able to reproduce it here (Mac OS X with a
32-bit libcaca/libcucul compiled from svn revision 1529.)

I will try to recompile libcaca and myman as 64-bit (amd64) and see if
that changes the behavior. Sadly I do not have a 64-bit Linux machine
to test on. In the meantime I fixed a few probably-unrelated bugs, and
enabled background color support in MyMan when using libcaca.
Previously only 16 color attribute combinations optionally with
reverse-video were allowed on screen at once, now it's 256 so that 16
foreground colors can combine with 16 background colors (and
optionally with reverse video.) Get the new version here:

http://zoehep.xent.com/~bsittler/myman-0.7pre4.tar.gz

Also, I had to patch a couple places to get that version of the
libraries to compile here on Mac OS X. Do the following patches look
OK to commit?

Thanks,
-Ben

Index: src/mygetopt.c
===================================================================
--- src/mygetopt.c      (revision 1529)
+++ src/mygetopt.c      (working copy)
@@ -26,8 +26,10 @@

 /* DOS / Kernel driver */
 #ifndef __intptr_t_defined
+#ifndef _UINTPTR_T
 typedef unsigned int           uintptr_t;
 #endif
+#endif

 #include <stdio.h>
 #include <string.h>
Index: cucul/figfont.c
===================================================================
--- cucul/figfont.c     (revision 1529)
+++ cucul/figfont.c     (working copy)
@@ -304,15 +304,20 @@
     /* Open font: if not found, try .tlf, then .flf */
     f = _cucul_file_open(path, "r");
 #if !defined __KERNEL__ && defined HAVE_SNPRINTF
+
+#if (! defined(snprintf)) && ( defined(_WIN32) || defined(WIN32) ) &&
(! defined(__CYGWIN__))
+#define snprintf _snprintf
+#endif
+
     if(!f)
     {
-        _snprintf(altpath, 2047, "%s.tlf", path);
+        snprintf(altpath, 2047, "%s.tlf", path);
         altpath[2047] = '\0';
         f = _cucul_file_open(altpath, "r");
     }
     if(!f)
     {
-        _snprintf(altpath, 2047, "%s.flf", path);
+        snprintf(altpath, 2047, "%s.flf", path);
         altpath[2047] = '\0';
         f = _cucul_file_open(altpath, "r");
     }
-- 
This is the libcaca mailing-list, see http://libcaca.zoy.org/
Trouble unsubscribing? Please contact <sam@zoy.org>
List archives are at http://libcaca.zoy.org/list/