Changeset 3585 for libcacaTweet

Timestamp:

Jul 27, 2009, 1:25:59 AM (13 years ago)

Author:

Sam Hocevar

Message:

Show how we could optimise dirty rectangle handling in a box fill. Disabled
for now because it does not work with fullwidth characters.

File:

• libcaca/trunk/caca/box.c (modified) (2 diffs)

libcaca/trunk/caca/box.c

@@ -1 +1 @@
 /*
  *  libcaca       Colour ASCII-Art library
- *  Copyright (c) 2002-2006 Sam Hocevar <sam@zoy.org>
+ *  Copyright (c) 2002-2009 Sam Hocevar <sam@hocevar.net>
  *                All Rights Reserved
  *
@@ -140 +140 @@
     if(y2 > ymax) y2 = ymax;
 
+#if 0
+    /* FIXME: this fails with fullwidth character blits. Also, the dirty
+     * rectangle handling may miss fullwidth cells. */
+    /* Optimise dirty rectangle handling, part 1 */
+    cv->dirty_disabled++;
+#endif
+
     for(j = y; j <= y2; j++)
         for(i = x; i <= x2; i++)
             caca_put_char(cv, i, j, ch);
+
+#if 0
+    /* Optimise dirty rectangle handling, part 2 */
+    cv->dirty_disabled--;
+    if(!cv->dirty_disabled)
+        caca_add_dirty_rect(cv, x, y, x2 - x + 1, y2 - y + 1);
+#endif
 
     return 0;