Changeset 3321Tweet

Timestamp:

Nov 10, 2008, 11:17:18 PM (14 years ago)

Author:

Pascal Terjan

Message:

• Don't create /dev/null when it is not there, some people may run neercs as root
• Display error when fork or opening /dev/null fails

File:

• neercs/trunk/src/server.c (modified) (3 diffs)

neercs/trunk/src/server.c

@@ -427 +427 @@
     if(pid < 0)
     {
-        fprintf(stderr, "Failed to create child process\n");
-        return 1;
+        perror("Failed to create child process");
+        return -1;
     }
     if(pid == 0)
@@ -436 +436 @@
         close(1);
         close(2);
-        fd = open("/dev/null", O_RDWR|O_CREAT, S_IRUSR|S_IWUSR);
+        fd = open("/dev/null", O_RDWR, 0);
+        if(fd < 0)
+        {
+            perror("Failed to open /dev/null");
+            return -2;
+        }
         dup2(fd, 0);
 #ifndef DEBUG
@@ -464 +469 @@
     screen_list->dp = caca_create_display(screen_list->cv);
     if(!screen_list->dp)
-        return 1;
+        return -3;
     caca_set_cursor(screen_list->dp, 1);