Changeset 303Tweet

Timestamp:

Jan 2, 2004, 4:34:16 PM (19 years ago)

Author:

Sam Hocevar

Message:

• src/graphics.c: + Split the drawing of foreground and background colours in the X11

driver. Nice performance improvement.

File:

• libcaca/trunk/src/graphics.c (modified) (3 diffs)

libcaca/trunk/src/graphics.c

@@ -872 +872 @@
         unsigned int x, y, len;
 
-        /* FIXME: This is very, very slow. There are several things that can
-         * be done in order to speed up things:
-         *  - cache characters once rendered
-         *  - pre-render all characters
-         *  - use our own rendering routine (screen depth dependent) */
+        /* First draw the background colours. Splitting the process in two
+         * loops like this is actually slightly faster. */
         for(y = 0; y < _caca_height; y++)
         {
@@ -884 +881 @@
 
                 len = 1;
-                while(x + len < _caca_width && attr[len] == attr[0])
+                while(x + len < _caca_width
+                       && (attr[len] >> 4) == (attr[0] >> 4))
                     len++;
 
@@ -891 +889 @@
                                x * x11_font_width, y * x11_font_height,
                                len * x11_font_width, x11_font_height);
+            }
+        }
+
+        /* Then print the foreground characters */
+        for(y = 0; y < _caca_height; y++)
+        {
+            for(x = 0; x < _caca_width; x += len)
+            {
+                unsigned char *attr = x11_attr + x + y * _caca_width;
+
+                len = 1;
+
+                /* Skip spaces */
+                if(x11_char[x + y * _caca_width] == ' ')
+                    continue;
+
+                while(x + len < _caca_width
+                       && (attr[len] & 0xf) == (attr[0] & 0xf))
+                    len++;
 
                 XSetForeground(x11_dpy, x11_gc, x11_colors[attr[0] & 0xf]);