Changeset 1191 for libcacaTweet

Timestamp:

Oct 6, 2006, 12:12:52 PM (17 years ago)

Author:

Sam Hocevar

Message:

• Fixed a bug in the IRC exporter that could break the output when there were commas in the canvas.

File:

• libcaca/trunk/cucul/export.c (modified) (2 diffs)

libcaca/trunk/cucul/export.c

@@ -517 +517 @@
             if((attr >> 16) == CUCUL_COLOR_TRANSPARENT)
                 bg = 0x10;
-#if 0
-            if(bg == prevbg)
-            {
-                if(fg == prevfg)
-                    ; /* Same fg/bg, do nothing */
-                else if(ch == (uint32_t)' ')
-                    fg = prevfg; /* Hackety hack */
-                else
-                {
-                    cur += sprintf(cur, "\x03%d", fg);
-                    if(ch >= (uint32_t)'0' && ch <= (uint32_t)'9')
-                        cur += sprintf(cur, "\x02\x02");
-                }
-            }
-            else
-            {
-                if(fg == prevfg)
-                    cur += sprintf(cur, "\x03,%d", bg);
-                else
-                    cur += sprintf(cur, "\x03%d,%d", fg, bg);
-
-                if(ch >= (uint32_t)'0' && ch <= (uint32_t)'9')
-                    cur += sprintf(cur, "\x02\x02");
-            }
-#else
+
+            /* TODO: optimise series of same fg / same bg
+             *       don't change fg value if ch == ' '
+             *       make sure the \x03,%d trick works everywhere */
             if(bg != prevbg || fg != prevfg)
             {
+                int need_escape = 0;
+
                 if(bg == 0x10)
                 {
                     if(fg == 0x10)
                         cur += sprintf(cur, "\x0f");
-                    else if(prevbg == 0x10)
-                        cur += sprintf(cur, "\x03%d", fg);
                     else
-                        cur += sprintf(cur, "\x0f\x03%d", fg);
+                    {
+                        if(prevbg == 0x10)
+                            cur += sprintf(cur, "\x03%d", fg);
+                        else
+                            cur += sprintf(cur, "\x0f\x03%d", fg);
+
+                        if(ch == (uint32_t)',')
+                            need_escape = 1;
+                    }
                 }
                 else
@@ -562 +549 @@
 
                 if(ch >= (uint32_t)'0' && ch <= (uint32_t)'9')
+                    need_escape = 1;
+
+                if(need_escape)
                     cur += sprintf(cur, "\x02\x02");
             }
-#endif
+
             cur += cucul_utf32_to_utf8(cur, ch);
             prevfg = fg;