Changeset 4001 for neercsTweet

Timestamp:

Nov 22, 2009, 4:01:24 PM (10 years ago)

Author:

Jean-Yves Lamoureux

Message:

• Fixed most of Clang Static Checker warnings. And rand() is ok to me, thank you.

Location:

neercs/trunk/src

Files:

• client.c (modified) (1 diff)
• configuration.c (modified) (5 diffs)
• grab.c (modified) (3 diffs)
• server.c (modified) (1 diff)

neercs/trunk/src/client.c

@@ -140 +140 @@
             if (!strncmp("DETACH", buf, 6))
             {
-                ret = 1;
+                /* ret = 1; Not used */
                 break;
             }

neercs/trunk/src/configuration.c

@@ -112 +112 @@
     fclose(fp);
 
-    i = 0;
-
     /* Parse it */
     while ((i =
@@ -133 +131 @@
 int parse_conf_line(char *buf, int size, struct screen_list *screen_list)
 {
-    int i, s = 0, eol = 0, c = 0;
+    int i, s = 0, c = 0;
     char *line = NULL;
     int l = 0;
@@ -157 +155 @@
         if (buf[i] == ';' && !in_quote)
         {
-            eol = i;
             break;
         }
         else if (buf[i] == '\n')
         {
-            eol = i;
             break;
         }
@@ -336 +332 @@
     int i = 0;
     struct option *option = screen_list->config;
-    char *section = NULL;
 
     while (option)
@@ -342 +337 @@
         if (option->key == NULL)
         {
-            section = option->key;
             option = option->next;
             continue;

neercs/trunk/src/grab.c

@@ -228 +228 @@
         /* FIXME check value of r */
         int r = asprintf(&fds, "%s/fd/*", pglob.gl_pathv[i]);
+        (void) r;
         glob(fds, GLOB_NOSORT, NULL, &pglob2);
         free(fds);
@@ -243 +244 @@
                 /* FIXME check value of r */
                 r = asprintf(&cmdfile, "%s/cmdline", pglob.gl_pathv[i]);
+                (void) r;
                 fd = open(cmdfile, O_RDONLY);
                 free(cmdfile);
@@ -249 +251 @@
                     /* FIXME check value of r */
                     r = read(fd, path, sizeof(path));
+                    (void) r;
                     (*process_list)[n].cmdline = strdup(path);
                     close(fd);

neercs/trunk/src/server.c

@@ -362 +362 @@
             {
                 request_refresh(screen_list);
-                refresh = 0;
                 screen_list->last_refresh_time = current_time;
             }