Changeset 3993Tweet

Timestamp:

Nov 21, 2009, 6:01:30 PM (14 years ago)

Author:

Sam Hocevar

Message:

Add a sanity check for coding style errors.

Location:

libcaca/trunk

Files:

• Makefile.am (modified) (1 diff)
• examples/.gitignore (modified) (1 diff)
• tests/check-build (modified) (2 diffs)

libcaca/trunk/Makefile.am

@@ -1 +1 @@
 # $Id$
 
-SUBDIRS = kernel caca src examples tests tools caca-sharp cxx python ruby doc
+SUBDIRS = kernel caca src examples tools caca-sharp cxx python ruby doc tests
 DIST_SUBDIRS = $(SUBDIRS) win32
 

libcaca/trunk/examples/.gitignore

@@ -24 +24 @@
 text
 transform
+trifiller
 truecolor
 unicode

libcaca/trunk/tests/check-build

@@ -1 +1 @@
 #!/bin/sh
 
-failure=0
+ret=0
+
+#
+# Check that the Win32 config.h is in sync with config.h.in
+#
 
 config_h_in=$(dirname "$0")/../config.h.in
 win32_config_h=$(dirname "$0")/../win32/config.h
 
+failure=0
 for key in $(sed -ne 's/.*#undef *\([A-Za-z0-9_]*\).*/\1/p' "$config_h_in");
 do
@@ -13 +18 @@
   fi
 done
-
 if test "$failure" != "0"; then
-  exit 1
+  ret=1
 else
   echo "0 errors in Win32 config.h"
 fi
 
+#
+# Check that we have no tabs or trailing spaces in the source code
+#
+failure=0
+for dir in caca cxx examples ruby tools; do
+  pushd ../$dir >/dev/null
+  # Dirty hack to print the $(SOURCES) variable
+  for x in $(make -s ID SHELL='echo @@$(SOURCES)@@' | tr -d '\n' | sed 's/.*@@\([^@]*\)@@.*/\1/');
+  do
+    if grep '[[:space:]]$' "$x" >/dev/null 2>&1; then
+      echo "error: $dir/$x contains trailing spaces"
+      failure=1
+    fi
+    if grep '   ' "$x" >/dev/null 2>&1; then
+      echo "error: $dir/$x contains tabs"
+      failure=1
+    fi
+  done
+  popd >/dev/null
+done
+if test "$failure" != "0"; then
+  ret=1
+else
+  echo "0 errors in source code"
+fi
+
+if test "$ret" != "0"; then
+  exit 1
+fi
+
 exit 0