Changeset 3398

Timestamp:

02/21/09 15:26:24 (4 years ago)

Author:

sam

Message:

Properly handle alpha components in the resize code.

File:

• libpipi/trunk/pipi/resize.c (modified) (8 diffs)

libpipi/trunk/pipi/resize.c

@@ -25 +25 @@
 #include "pipi_internals.h"
 
+/* FIXME: the algorithm does not handle alpha components properly. Resulting
+ * alpha should be the mean alpha value of the neightbouring pixels, but
+ * the colour components should be weighted with the alpha value. */
 pipi_image_t *pipi_resize(pipi_image_t *src, int w, int h)
 {
@@ -42 +45 @@
     dw = dst->w; dh = dst->h;
 
-    aline = malloc(3 * dw * sizeof(float));
-    line = malloc(3 * dw * sizeof(float));
+    aline = malloc(4 * dw * sizeof(float));
+    line = malloc(4 * dw * sizeof(float));
 
-    memset(line, 0, 3 * dw * sizeof(float));
+    memset(line, 0, 4 * dw * sizeof(float));
     remy = 0;
 
@@ -52 +55 @@
         int toty = 0, ny;
 
-        memset(aline, 0, 3 * dw * sizeof(float));
+        memset(aline, 0, 4 * dw * sizeof(float));
 
         while(toty < sh)
@@ -58 +61 @@
             if(remy == 0)
             {
-                float r = 0, g = 0, b = 0;
+                float r = 0, g = 0, b = 0, a = 0;
                 int remx = 0;
 
                 for(x = 0, x0 = 0; x < dw; x++)
                 {
-                    float ar = 0, ag = 0, ab = 0;
+                    float ar = 0, ag = 0, ab = 0, aa = 0;
                     int totx = 0, nx;
 
@@ -73 +76 @@
                             g = srcdata[(y0 * sw + x0) * 4 + 1];
                             b = srcdata[(y0 * sw + x0) * 4 + 2];
+                            a = srcdata[(y0 * sw + x0) * 4 + 3];
                             x0++;
                             remx = dw;
@@ -78 +82 @@
 
                         nx = (totx + remx <= sw) ? remx : sw - totx;
-                        ar += nx * r; ag += nx * g; ab += nx * b;
+                        ar += nx * r; ag += nx * g; ab += nx * b; aa += nx * a;
                         totx += nx;
                         remx -= nx;
                     }
 
-                    line[3 * x] = ar;
-                    line[3 * x + 1] = ag;
-                    line[3 * x + 2] = ab;
+                    line[4 * x] = ar;
+                    line[4 * x + 1] = ag;
+                    line[4 * x + 2] = ab;
+                    line[4 * x + 3] = aa;
                 }
 
@@ -95 +100 @@
             for(x = 0; x < dw; x++)
             {
-                aline[3 * x] += ny * line[3 * x];
-                aline[3 * x + 1] += ny * line[3 * x + 1];
-                aline[3 * x + 2] += ny * line[3 * x + 2];
+                aline[4 * x] += ny * line[4 * x];
+                aline[4 * x + 1] += ny * line[4 * x + 1];
+                aline[4 * x + 2] += ny * line[4 * x + 2];
+                aline[4 * x + 3] += ny * line[4 * x + 3];
             }
             toty += ny;
@@ -105 +111 @@
         for(x = 0; x < dw; x++)
         {
-            dstdata[(y * dw + x) * 4] = aline[3 * x] / (sw * sh);
-            dstdata[(y * dw + x) * 4 + 1] = aline[3 * x + 1] / (sw * sh);
-            dstdata[(y * dw + x) * 4 + 2] = aline[3 * x + 2] / (sw * sh);
+            dstdata[(y * dw + x) * 4] = aline[4 * x] / (sw * sh);
+            dstdata[(y * dw + x) * 4 + 1] = aline[4 * x + 1] / (sw * sh);
+            dstdata[(y * dw + x) * 4 + 2] = aline[4 * x + 2] / (sw * sh);
+            dstdata[(y * dw + x) * 4 + 3] = aline[4 * x + 3] / (sw * sh);
         }
     }