Changeset 2643Tweet

Timestamp:

Aug 2, 2008, 2:12:58 PM (14 years ago)

Author:

Sam Hocevar

Message:

• blur.c: adapt the kernel size to large values of dx and/or dy.
• blur.c: fix the dx/dy sign meaning.

File:

• libpipi/trunk/pipi/filter/blur.c (modified) (4 diffs)

libpipi/trunk/pipi/filter/blur.c

@@ -67 +67 @@
     buffer = malloc(w * h * (gray ? 1 : 4) * sizeof(double));
 
-    kr = (int)(3. * rx + 1.99999);
+    /* FIXME: the kernel becomes far too big with large values of dx, because
+     * we grow both left and right. Fix the growing direction. */
+    kr = (int)(3. * rx + .99999 + ceil(abs(dx)));
     kw = 2 * kr + 1;
     K = -1. / (2. * rx * rx);
@@ -73 +75 @@
     kernel = malloc(kw * sizeof(double));
     for(i = -kr; i <= kr; i++)
-        kernel[i + kr] = exp(K * ((double)i - dx) * ((double)i - dx));
+        kernel[i + kr] = exp(K * ((double)i + dx) * ((double)i + dx));
 
     for(y = 0; y < h; y++)
@@ -126 +128 @@
     free(kernel);
 
-    kr = (int)(3. * ry + 1.99999);
+    kr = (int)(3. * ry + .99999 + ceil(abs(dy)));
     kw = 2 * kr + 1;
     K = -1. / (2. * ry * ry);
@@ -132 +134 @@
     kernel = malloc(kw * sizeof(double));
     for(i = -kr; i <= kr; i++)
-        kernel[i + kr] = exp(K * ((double)i - dy) * ((double)i - dy));
+        kernel[i + kr] = exp(K * ((double)i + dy) * ((double)i + dy));
 
     for(y = 0; y < h; y++)