Changeset 2483Tweet

Timestamp:

Jun 24, 2008, 3:21:35 PM (14 years ago)

Author:

Sam Hocevar

Message:

• Fix a buffer overflow in the reattach code.

File:

• neercs/trunk/src/attach.c (modified) (1 diff)

neercs/trunk/src/attach.c

@@ -104 +104 @@
 }
 
-/* FIXME Is this really not defined anywhere ? */
-#define MIN(X,Y) ((X) < (Y) ? (X) : (Y))
-
 static int handle_command(char * cmd, struct screen_list* screen_list, cucul_canvas_t * cv, caca_display_t ** dp)
 {
     int refresh = 0;
     debug("Received command %s", cmd);
-    if(!strncmp("ENV ", cmd, MIN(4, strlen(cmd))))
+    if(!strncmp("ENV ", cmd, 4))
     {
         putenv(strdup(cmd+4));
     }
-    else if(!strncmp("ATTACH ", cmd, MIN(7, strlen(cmd))))
+    else if(!strncmp("ATTACH ", cmd, 7))
     {
         int fd;