Changeset 2305 for libcaca/trunk/caca/event.cTweet

Timestamp:

Apr 19, 2008, 9:25:52 PM (12 years ago)

Author:

Sam Hocevar

Message:

• Remove all unsigned ints from exported functions. Signed arithmetic is far better for error checking.

File:

• libcaca/trunk/caca/event.c (modified) (10 diffs)

libcaca/trunk/caca/event.c

@@ -64 +64 @@
  *  \return 1 if a matching event was received, or 0 if the wait timeouted.
  */
-int caca_get_event(caca_display_t *dp, unsigned int event_mask,
+int caca_get_event(caca_display_t *dp, int event_mask,
                    caca_event_t *ev, int timeout)
 {
@@ -128 +128 @@
  *  \return The X mouse coordinate.
  */
-unsigned int caca_get_mouse_x(caca_display_t const *dp)
-{
-    unsigned int width = cucul_get_canvas_width(dp->cv);
+int caca_get_mouse_x(caca_display_t const *dp)
+{
+    int width = cucul_get_canvas_width(dp->cv);
 
     if(dp->mouse.x >= width)
@@ -150 +150 @@
  *  \return The Y mouse coordinate.
  */
-unsigned int caca_get_mouse_y(caca_display_t const *dp)
-{
-    unsigned int height = cucul_get_canvas_height(dp->cv);
+int caca_get_mouse_y(caca_display_t const *dp)
+{
+    int height = cucul_get_canvas_height(dp->cv);
 
     if(dp->mouse.y >= height)
@@ -199 +199 @@
  *  \return The key value.
  */
-unsigned int caca_get_event_key_ch(caca_event_t const *ev)
+int caca_get_event_key_ch(caca_event_t const *ev)
 {
     return ((caca_privevent_t const *)ev)->data.key.ch;
@@ -250 +250 @@
  *  \return The event's mouse button.
  */
-unsigned int caca_get_event_mouse_button(caca_event_t const *ev)
+int caca_get_event_mouse_button(caca_event_t const *ev)
 {
     return ((caca_privevent_t const *)ev)->data.mouse.button;
@@ -266 +266 @@
  *  \return The event's X mouse coordinate.
  */
-unsigned int caca_get_event_mouse_x(caca_event_t const *ev)
+int caca_get_event_mouse_x(caca_event_t const *ev)
 {
     return ((caca_privevent_t const *)ev)->data.mouse.x;
@@ -282 +282 @@
  *  \return The event's Y mouse coordinate.
  */
-unsigned int caca_get_event_mouse_y(caca_event_t const *ev)
+int caca_get_event_mouse_y(caca_event_t const *ev)
 {
     return ((caca_privevent_t const *)ev)->data.mouse.y;
@@ -298 +298 @@
  *  \return The event's new display width value.
  */
-unsigned int caca_get_event_resize_width(caca_event_t const *ev)
+int caca_get_event_resize_width(caca_event_t const *ev)
 {
     return ((caca_privevent_t const *)ev)->data.resize.w;
@@ -314 +314 @@
  *  \return The event's new display height value.
  */
-unsigned int caca_get_event_resize_height(caca_event_t const *ev)
+int caca_get_event_resize_height(caca_event_t const *ev)
 {
     return ((caca_privevent_t const *)ev)->data.resize.h;
@@ -326 +326 @@
 {
 #if defined(USE_SLANG) || defined(USE_NCURSES)
-    unsigned int ticks;
+    int ticks;
 #endif
     int ret;