Changeset 1251 for cacamooTweet

Timestamp:

Oct 28, 2006, 10:22:58 AM (16 years ago)

Author:

Jean-Yves Lamoureux

Message:

• Fixed buffer overflow in replace function (still need to be fixed in a more clever way)

File:

• cacamoo/trunk/src/main.c (modified) (3 diffs)

cacamoo/trunk/src/main.c

@@ -283 +283 @@
         free(buffer);
 
+    cucul_free_buffer(input_buffer);
+    cucul_free_buffer(output_buffer);
+    cucul_free_canvas(canvas);
+
+
     return 0;
 }
@@ -511 +516 @@
     char *c = NULL;
     char *newstr = NULL;
+    char *orig = str;
 
     if(oldpiece==NULL || newpiece==NULL)
         return NULL;
 
-    if ((c = (char *) strstr(str, oldpiece)) == NULL) {
+    if ((c = (char *) strstr(str, oldpiece)) == NULL)
         return str;
-    }
-
-    newstr = malloc(1024);
+
+
+    newstr = malloc(8192); // FIXME
 
     if(newstr == NULL)
@@ -553 +559 @@
     strcpy(newstr+newstr_index, str+str_index);
 
+    str = orig;
     return newstr;
 }